New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print error messages to stderr #102

Merged

AlexWaygood merged 2 commits into sphinx-contrib:main from rffontenelle:patch-1

Nov 22, 2023

Contributor

rffontenelle commented Nov 18, 2023 •

edited

Loading

Example of result of this change:

# Here is a file with reST issues.
$ sphinx-lint bad.po
bad.po:27: role with no backticks: ' :ref:kept ' (role-without-backticks)
$ sphinx-lint bad.po > /dev/null
bad.po:27: role with no backticks: ' :ref:kept ' (role-without-backticks)

# Here is a file with no issue.
$ sphinx-lint good.po
No problems found.
$ sphinx-lint good.po > /dev/null

Fixes #101


          Print error messages to stderr

b1d17dc

AlexWaygood approved these changes

View reviewed changes

Collaborator

AlexWaygood left a comment

LGTM, thanks! Will leave open for a day or two in case any other maintainers have objections

Collaborator

AlexWaygood commented Nov 18, 2023

Oh, looks like a bunch of tests need to be updated, since we're now sending errors to stderr, but our test suite currently assumes they'll be sent to stdout


          Update tests for errors now in stderr

09669bb

Contributor Author

rffontenelle commented Nov 18, 2023

Yay, in the last commit I managed to achieve 102 passed, 1 skipped in 0.28s

AlexWaygood approved these changes

View reviewed changes

AlexWaygood merged commit ac9d13a into sphinx-contrib:main

18 checks passed

rffontenelle deleted the patch-1 branch

November 22, 2023 09:56

Collaborator

AlexWaygood commented Nov 22, 2023

Released in v0.9.0: https://github.com/sphinx-contrib/sphinx-lint/releases/tag/v0.9.0

lengau referenced this pull request in canonical/craftcraft


          chore(deps): update dependency docs/sphinx-lint to v0.9.1 (#9)

597c43a

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [docs/sphinx-lint](https://togithub.com/sphinx-contrib/sphinx-lint)
([changelog](https://togithub.com/sphinx-contrib/sphinx-lint/releases))
| `==0.8.2` -> `==0.9.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/docs%2fsphinx-lint/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/docs%2fsphinx-lint/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/docs%2fsphinx-lint/0.8.2/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/docs%2fsphinx-lint/0.8.2/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>sphinx-contrib/sphinx-lint (docs/sphinx-lint)</summary>

###
[`v0.9.1`](https://togithub.com/sphinx-contrib/sphinx-lint/releases/tag/v0.9.1)

[Compare
Source](https://togithub.com/sphinx-contrib/sphinx-lint/compare/v0.9.0...v0.9.1)

#### What's Changed

- Add `tool.hatch.build.targets.wheel` to fix `pip install .` with
Hatchling 1.19 by [@&#8203;hugovk](https://togithub.com/hugovk) in
[https://github.com/sphinx-contrib/sphinx-lint/pull/106](https://togithub.com/sphinx-contrib/sphinx-lint/pull/106)
This fixes `ValueError: Unable to determine which files to ship inside
the wheel using the following heuristics: [...]` when trying to `pip
install .`, including via pre-commit.
- Add tox for easy testing of multiple Python versions by
[@&#8203;hugovk](https://togithub.com/hugovk) in
[https://github.com/sphinx-contrib/sphinx-lint/pull/100](https://togithub.com/sphinx-contrib/sphinx-lint/pull/100)
- Lint on GitHub Actions via pre-commit by
[@&#8203;hugovk](https://togithub.com/hugovk) in
[https://github.com/sphinx-contrib/sphinx-lint/pull/104](https://togithub.com/sphinx-contrib/sphinx-lint/pull/104)

**Full Changelog**:
sphinx-contrib/sphinx-lint@v0.9.0...v0.9.1

###
[`v0.9.0`](https://togithub.com/sphinx-contrib/sphinx-lint/releases/tag/v0.9.0)

[Compare
Source](https://togithub.com/sphinx-contrib/sphinx-lint/compare/v0.8.2...v0.9.0)

#### What's Changed

- Print error messages to stderr by
[@&#8203;rffontenelle](https://togithub.com/rffontenelle) in
[https://github.com/sphinx-contrib/sphinx-lint/pull/102](https://togithub.com/sphinx-contrib/sphinx-lint/pull/102)

#### New Contributors

- [@&#8203;rffontenelle](https://togithub.com/rffontenelle) made their
first contribution in
[https://github.com/sphinx-contrib/sphinx-lint/pull/102](https://togithub.com/sphinx-contrib/sphinx-lint/pull/102)

**Full Changelog**:
sphinx-contrib/sphinx-lint@v0.8.2...v0.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" in timezone Etc/UTC,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/canonical/craftcraft).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet