Use pre-compiled regular expressions #77
Conversation
These speed up linting by potentially big factors (e.g., linting CPython/Docs/library/*.rst is ~25% faster locally). Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
There was a problem hiding this comment.
LGTM! This gets us most of the way to the speedup I reported in #76 (comment) :D
There's a few other things we can do to speed things up further, but I can tackle them in a followup PR tomorrow, since I've already got them around locally :)
|
A lot of precompiled regexes in this repo seem to be located in |
I think they're fine where they are, but no strong opinion either way :) |
Let's leave them where they are for now! |
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
The latter seems to be what the current codebase calls Pattern objects, so let's not add confusion. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
|
Sorry, just added another one after another quick profiling, and renamed the |
There was a problem hiding this comment.
Running with main on CPython docs:
❯ time sphinx-lint Doc
No problems found.
sphinx-lint Doc 17.89s user 0.31s system 672% cpu 2.705 totalAnd this PR:
❯ time sphinx-lint Doc
No problems found.
sphinx-lint Doc 13.98s user 0.30s system 641% cpu 2.225 totalA nice 18% improvement! Again almost too easy!
|
With both this and #79: ❯ time sphinx-lint Doc
No problems found.
sphinx-lint Doc 11.93s user 0.31s system 626% cpu 1.954 total27% improvement! 🎉 |
Some low-hanging fruit inspired by #76.