Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towncrier 19.9 compatibility #44

Closed
uranusjr opened this issue Jan 20, 2021 · 3 comments · Fixed by #47
Closed

Towncrier 19.9 compatibility #44

uranusjr opened this issue Jan 20, 2021 · 3 comments · Fixed by #47
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@uranusjr
Copy link

Towncrier changed internals nad now the extension errors with

Extension error:
Handler <bound method TowncrierDraftEntriesEnvironmentCollector.get_outdated_docs of <sphinxcontrib.towncrier.TowncrierDraftEntriesEnvironmentCollector object at 0x10fb098b0>>
for event 'env-get-outdated' threw an exception
(exception: load_config_from_file() missing 1 required positional argument: 'config_file')
@webknjaz
Copy link
Member

webknjaz commented Jan 21, 2021

Thanks for the report!

@slsh1o do you want to try and fix this? I guess this should be reproducible with pip install git+https://github.com/twisted/towncrier.git.

@webknjaz webknjaz added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jan 21, 2021
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Apr 12, 2021
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Apr 13, 2021
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Apr 14, 2021
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Apr 14, 2021
@webknjaz
Copy link
Member

@Cadair I saw you mentioned this issue @ astropy/astropy#11279 (comment). So FYI it's been fixed by @s0undt3ch in #47. I'll try to make a release soon.

Also TIL about https://github.com/OpenAstronomy/sphinx-changelog — I'll probably link it from the README pointing to similar projects. For now, just documenting that it exists in this comment tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants