-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added width compatibility for mobiles! #140
base: master
Are you sure you want to change the base?
Conversation
During the build of alabaster docs, I am facing this issue!:
So, after merging this, we can get something like this without further tweaks: |
Re: #139 - can you provide some details on exactly what behavior I should be confirming is fixed here? Thanks! Offhand I don't see a huge problem with this but I'm still curious what exactly it's solving. (At this point in time I am hoping nobody would ever try loading up a Sphinx doc site on <250px display...probably? :D) |
Hi! @bitprophet . Currently, if you try to view https://inb.readthedocs.io/en/latest/ in mobile, or any device less than 450px(which is a lot TBH), you have to scroll left and right to read things (Which gets quite disastrous). I kept 250px to be on a safe side. Mobiles generally have screen size from 290px to 400 px. See this, in which I fixed this problem.
True, indeed that's why I kept it as a min device width :D |
One can always put some custom CSS, but I guess responsiveness must be shipped with the theme. |
I noticed this bug in all alabaster themed website using my mobile phone. |
I make a PR related this! I am glad if you can see! |
Is there a reason not to merge this PR? |
Solves #139
@bitprophet Please Review!