Skip to content

Commit

Permalink
Bump to 1.5.5 final
Browse files Browse the repository at this point in the history
  • Loading branch information
@tk0miya
tk0miya committed Apr 3, 2017
1 parent 86c19bd commit 5dd51a7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
16 changes: 2 additions & 14 deletions CHANGES
View file
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
Release 1.5.5 (in development)
==============================

Incompatible changes
--------------------

Deprecated
----------

Features added
--------------
Release 1.5.5 (released Apr 03, 2017)
=====================================

Bugs fixed
----------

* #3597: python domain raises UnboundLocalError if invalid name given
* #3599: Move to new Mathjax CDN

Testing
--------

Release 1.5.4 (released Apr 02, 2017)
=====================================

Expand Down
4 changes: 2 additions & 2 deletions sphinx/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@
warnings.filterwarnings('ignore', "'U' mode is deprecated",
DeprecationWarning, module='docutils.io')

__version__ = '1.5.5+'
__version__ = '1.5.5'
__released__ = '1.5.5' # used when Sphinx builds its own docs

# version info for better programmatic use
# possible values for 3rd element: 'alpha', 'beta', 'rc', 'final'
# 'final' has 0 as the last element
version_info = (1, 5, 5, 'beta', 0)
version_info = (1, 5, 5, 'final', 0)

package_dir = path.abspath(path.dirname(__file__))

Expand Down

4 comments on commit 5dd51a7

@mitya57
Copy link
Contributor

@mitya57 mitya57 commented on 5dd51a7 Apr 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tk0miya!

The tarball for 1.5.5 release contains a file named Sphinx.egg-info/PKG-INFO-e which has this content:

Metadata-Version: 1.1
Name: Sphinx
Version: 1.6.dev20170322

This seems very suspicious… Also there are other -e files: Sphinx.egg-info/dependency_links.txt-e, Sphinx.egg-info/entry_points.txt-e and others.

Was it intended to put them into the tarball?

@tk0miya
Copy link
Member Author

@tk0miya tk0miya commented on 5dd51a7 Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's not intended, it's some kind of mistake.
Is 1.5.6 needed?
If none, I will check our release script. We need to clear garbages before packaging.

@mitya57
Copy link
Contributor

@mitya57 mitya57 commented on 5dd51a7 Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.5.6 is not needed, but I want to ask you to avoid such stuff in the future.

@tk0miya
Copy link
Member Author

@tk0miya tk0miya commented on 5dd51a7 Apr 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found our release script does not remove Sphinx.egg-info directory on packaging.
I guess the *-e files were generated on my mis-operations.
I fixed the script now (a9256bf), so it will be not contained in next release.
Thanks!

Please sign in to comment.