Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML search should set noindex #11697

Closed
AA-Turner opened this issue Sep 29, 2023 · 5 comments · Fixed by #11700
Closed

HTML search should set noindex #11697

AA-Turner opened this issue Sep 29, 2023 · 5 comments · Fixed by #11700
Labels

Comments

@AA-Turner
Copy link
Member

search.html should set the <meta name="robots" content="noindex"> tag.

A

@hugovk
Copy link
Contributor

hugovk commented Sep 29, 2023

Another search tip, there's also a new <search> element:

https://webkit.org/blog/14445/webkit-features-in-safari-17-0/

Perhaps we can replace this <div>?

<div id="searchbox" style="display: none" role="search">

The article mentions the ARIA role="search" should be kept until there's wider browser support.

@AA-Turner
Copy link
Member Author

AA-Turner commented Sep 29, 2023

It seems very new. However, From Safari's blog post:

We are excited to be the first browser to ship this new <search> element, now supported in Safari 17.0.

...

Browsers without support for the search element will recognize there is an element present, and they will recognize any attributes it has — including roles, IDs, and classes. It will simply behave like a generic element, as if it were a <div>. Because of this, we recommend you include an ARIA search role on the <search> element for now. By using <search role="search">, you will ensure every user has the intended experience. And in the future, when all browsers have support, you can drop the ARIA search role.

In the meantime, you can start using <search> today with confidence, long before a significant percent [sic] of your audience use browsers with support.

So it seems that even though only one browser supports the element, we can start using it, and nothing will break.

A

@jdillard
Copy link
Contributor

jdillard commented Oct 3, 2023

@hugovk might be best to create a new issue for the search tag #11697 (comment)? Unless it gets added to #11700, this issue is likely to be closed and could end up overlooked.

@jayaddison
Copy link
Contributor

For transparency: yep, I'm not currently planning to add support for the HTML search element in #11700 (could do, although I'd probably tend to wait until the caniuse stats increase)

@hugovk
Copy link
Contributor

hugovk commented Oct 3, 2023

Sure, new issue created at #11701. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants