-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autodoc] add support for python_display_short_literal
#12003
base: master
Are you sure you want to change the base?
[autodoc] add support for python_display_short_literal
#12003
Conversation
So now, we have another flaky test on windows 😆 It's entirely caused by the network so I don't have a good way to make it "safe and easy" |
Sorry that I didn't notice this earlier (I disabled my |
About the Python3.13 test failures:
|
The PPA functionality of Launchpad appears to be restored; I'm not yet certain about the status of their other services. |
Co-authored-by: James Addison <55152140+jayaddison@users.noreply.github.com>
The output from the latest commit at 032bf8c appears to solve the problem in the minimal-repro case: |
(oops; I'm not claiming that that commit fixed it -- it's the one the screenshot was taken from though) |
I'll review a last time tomorrow when I'm on Linux before merging it. |
Oh, now that the PRs for refactoring typing are merged, I can fix that one back ! |
…display-short-literal # Conflicts: # CHANGES.rst # sphinx/util/inspect.py # sphinx/util/typing.py
I'll need to solve those conflicts in my IDE because it'll be too hard otherwise. |
…display-short-literal # Conflicts: # sphinx/ext/autodoc/__init__.py # sphinx/util/typing.py
Closes #11995.
@user27182 Could you check if this patch works? I added a test but since I refactored autodoc for that, I want to be sure that I didn't forget some places (and this can essentially be checked with large projects).
I won't merge this one until I get approval from another maintainer since it's a fairly sensitive component.