-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: implement readiness check before yielding local-http(s) test servers #12050
Merged
picnixz
merged 19 commits into
sphinx-doc:master
from
jayaddison:issue-12038/increase-https-selfsigned-test-timeout
Mar 8, 2024
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
396b8df
tests: increase timeout for linkcheck local-https test server
jayaddison cf50d4c
Revert "tests: increase timeout for linkcheck local-https test server"
jayaddison 911d9c9
tests: implement socket-based healthcheck before yielding test HTTP(S…
jayaddison c3075c5
tests: update error message for non-responsive test server: healthche…
jayaddison 34c2527
tests: remove fairly-redundant exception re-raise logic
jayaddison 813c23c
tests: resource cleanup: close the readiness-check client socket
jayaddison 912b55e
tests: refactor-out single-use variable
jayaddison cf149ad
tests: test server setup: add explanatory comment
jayaddison 8c3751e
Add CHANGES.rst entry
jayaddison 4364c6c
ci: run a matrix of Windows tests, and temporarily disable Ubuntu tests
jayaddison 6bb4797
ci: fixup: relocate temporary 'if' condition
jayaddison 95dd097
Code review: change variable name 'HOST' to 'ADDRESS'
jayaddison 9720039
Code review: use a context-manager to handle client socket connection…
jayaddison 1442999
Revert "Code review: use a context-manager to handle client socket co…
jayaddison 6b2f11b
tests: attempt to improve commentary and link it more closely with th…
jayaddison df5687e
Revert "ci: fixup: relocate temporary 'if' condition"
jayaddison ed1144d
Revert "ci: run a matrix of Windows tests, and temporarily disable Ub…
jayaddison 7719f1c
tests: nitpick: add full-stops to comment sentences (despite their qu…
jayaddison ea77de2
tests: nitpick: capitalize comment sentences.
jayaddison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to end your sentences with periods you should also start with a capital letter (I think it's fine not to have a period for non-capitalized small comments in general)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's reasonable :)
The full-stop was partly to reduce the chance that one or other of the lines could be deleted, leaving the other one parse as valid but without the relevant context.