-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] linkcheck: bind each test HTTP server to a unique port per-testcase. #12126
[tests] linkcheck: bind each test HTTP server to a unique port per-testcase. #12126
Conversation
… our dependency on the 'port' variable.
…les in intersphinx test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes I want to use a specific port (either because I don't trust Python or my OS, or I want to check that it fails because I know the port is busy) so I'd suggest this.
I'm sorry I didn't suggest this before by the way.
…ts; add a changelog entry instead. Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz going back to check that I haven't overlooked things: was there a compelling reason to prefer using only recognizable-as-maybe-test port numbers like these? I think the port |
Not really. It's just that I think it would have been easier to debug in general. |
In situations where an individual test is being troublesome, and repeating it and perhaps inspecting the network requests to try to debug that, this seems very true. Perhaps an environment variable ( |
Not really, if you have a port issue, you would just explicitly use the port (that's why I asked you that you could explicitly change the port number if needed). We could consider it in another PR if we see that we need it. By the way, I'm updating the branch, waiting for everything to work and then LGTM. |
Thank you ! |
Thank you @picnixz for the code reviews and suggestions 👍 |
Feature or Bugfix
Purpose
linkcheck
builder tests can interfere with each other.linkcheck
builder tests to run in arbitrary order.Detail
0
, as illustrated in the Python documentation'ssocketserver
sample code forThreadingMixIn
.localhost:{port}
address for each test that it can makelinkcheck
builder requests to.localhost:7777
duringlinkcheck
tests to remap these to the test-specific HTTP(S) server.filelock
dependency from our test dependencies since as this should no longer be required with the above changes in place.Relates