Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] linkcheck: expect and check for a docutils raw HTTP request during testsuite. #12143

Closed

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix (improved test isolation)

Purpose

  • Improve test isolation of the linkcheck builder test_raw_node test case.

Detail

  • Patch a docutils HTTP request that occurs when processing a raw directive during testing.

Relates

@jayaddison
Copy link
Contributor Author

Apologies for the notification noise from opening this pull request; I've found a better approach that doesn't require mocking and that is compatible across the versions of docutils that we test with.

@jayaddison jayaddison closed this Mar 19, 2024
@jayaddison jayaddison deleted the tests/patch-docutils-urlopen branch March 19, 2024 17:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant