Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Increase timeouts for linkcheck build tests. #12166

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Workaround

Purpose

  • Reduce distration due to failed continuous integration pipelines.

Detail

  • Increase the timeout duration in linkcheck-related test roots by a factor of 5x, to a quarter-second.

Relates

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers. Well the tests are at least passing in this instance, so thats a good start. If it stops the issue with the flaky test failure, then pragmatically I think its a good idea, and we can bear in mind fixing the root cause at a later date

@chrisjsewell chrisjsewell changed the title [tests] Attempt to resolve disruptive linkcheck test flakiness by increasing timeouts. [tests] Increase timeouts for linkcheck build tests. Mar 21, 2024
@chrisjsewell chrisjsewell merged commit 4eede5c into sphinx-doc:master Mar 21, 2024
22 checks passed
@jayaddison
Copy link
Contributor Author

Thanks @chrisjsewell - and yep, exactly - hopefully an improvement even if not a complete fix.

@jayaddison jayaddison deleted the issue-12159/tests-increase-linkcheck-timeouts branch March 21, 2024 20:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/test_builders/test_build_linkcheck.py::test_defaults flaky for docutils HEAD CI
3 participants