"minversion" should be a string, not a float

[DimitriPapadopoulos]

Subject: fix repo-review crash

Feature or Bugfix

• Bugfix

Purpose

This fixes a crash of repo-review:

Traceback (most recent call last):
  File "/lib/python311.zip/_pyodide/_base.py", line 468, in eval_code
    .run(globals, locals)
     ^^^^^^^^^^^^^^^^^^^^
  File "/lib/python311.zip/_pyodide/_base.py", line 310, in run
    coroutine = eval(self.code, globals, locals)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "", line 9, in 
  File "/lib/python3.11/site-packages/repo_review/processor.py", line 214, in process
    result = apply_fixtures({"name": name, **fixtures}, tasks[name].check)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python3.11/site-packages/repo_review/fixtures.py", line 106, in apply_fixtures
    return func(**kwargs)
           ^^^^^^^^^^^^^^
  File "/lib/python3.11/site-packages/sp_repo_review/checks/pyproject.py", line 92, in check
    return "minversion" in options and int(options["minversion"].split(".")[0]) >= 6
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'float' object has no attribute 'split'

Details

• Documentation of pytest:
  https://docs.pytest.org/en/7.3.x/reference/customize.html#pyproject-toml

Relates

• AttributeError: 'float' object has no attribute 'split' scientific-python/cookie#404

[AA-Turner]

A string seems semantically wrong here -- the minimum version is a number as it currently stands.

A

[DimitriPapadopoulos]

Versions are not floats. Omitting the quotes results in 6.0 being interpreted as a float, which is semantically wrong. The only way in TOML to not read this is as a float is a string. Besides, if you look at pyproject.toml, versions always appear as strings.

Also, the documentation of pytest itself suggests a string in TOML files (and only TOML file):
https://docs.pytest.org/en/7.3.x/reference/customize.html#pyproject-toml