Improve type hints for sphinx.ext.autodoc.mock
#12280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
changed the title
sphinx.ext.autodoc.mocksphinx.ext.autodoc.mock [part 2a]
AA-Turner
changed the title
sphinx.ext.autodoc.mock [part 2a]sphinx.ext.autodoc.mock type hints
AA-Turner
changed the title
sphinx.ext.autodoc.mock type hintssphinx.ext.autodoc.mock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-PR of #12257.
This fixes an unrelated bug in the tests where the signature of the expectation changes according to whether
typing.Anyis present or not. I assumed in this PR that it should not be present at runtime since otherwise it might not be the case and I added a comment if someone mistakingly changed that assumption (it took me some time to figure out why it failed).I also removed the file from the ruff exclusion list (since the changes are not that great) and from some mypy exclusion list as well.