Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid attribute indirection with env #13212

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Avoid attribute indirection with env #13212

merged 2 commits into from
Jan 5, 2025
+181 −160

Conversation

AA-Turner
Copy link
Member

Purpose

BuildEnvironment exposes several attributes which often exist elsewhere (e.g. builder.env.config vs builder.config). This PR removes redundant indirections where possible

References

A

@AA-Turner AA-Turner mentioned this pull request Jan 5, 2025
Open
@AA-Turner AA-Turner merged commit 83bf866 into sphinx-doc:master Jan 5, 2025
22 checks passed
@AA-Turner AA-Turner added this to the 8.2.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internals:refactoring
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AA-Turner