linkcheck: disallow 'None' value for 'linkcheck_allowed_redirects' setting #13483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Patches the
linkcheck
module so thatlinkcheck_allowed_redirects
is never assigned a value ofNone
-- this was failing to typecheck against the allowed values for the config value when HTML themes were enabled (ref: #13462).The range of possible values for the config setting are:
linkcheck_allowed_redirects:{}
: default follow redirects to attempt to resolve them, and emit warnings when redirects occur.linkcheck_allowed_redirects:_sentinel_lar
: follow redirects to attempt to resolve them, and do not warn about them.linkcheck_allowed_redirects:{...}
: follow redirects to attempt to resolve them, and warn about any that do not resolve to the expected destinations.References
linkcheck_allowed_redirects
is non-empty #13439.