Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intersphinx: Normalize mapping on config-inited #5826

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Dec 17, 2018

Feature or Bugfix

  • Refactoring

Purpose

  • The main loop of load_mappings() is too complicated. To make it simple, this tries to normalize intersphinx_mapping on config-inited event.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #5826 into master will decrease coverage by 0.03%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5826      +/-   ##
==========================================
- Coverage   83.29%   83.26%   -0.04%     
==========================================
  Files         290      292       +2     
  Lines       39290    39338      +48     
  Branches     5864     5868       +4     
==========================================
+ Hits        32728    32756      +28     
- Misses       5210     5227      +17     
- Partials     1352     1355       +3
Impacted Files Coverage Δ
tests/test_ext_intersphinx.py 100% <100%> (ø) ⬆️
sphinx/ext/intersphinx.py 88.28% <84.21%> (-1.12%) ⬇️
sphinx/__init__.py 73.91% <0%> (ø)
sphinx/make_mode.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a199c0...556f599. Read the comment docs.

@tk0miya tk0miya merged commit f04e161 into sphinx-doc:master Dec 18, 2018
@tk0miya tk0miya deleted the refactor_intersphinx branch December 18, 2018 14:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant