Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #7144: Add CSS class indicating its domain for each desc node #7145

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Feb 13, 2020

Feature or Bugfix

  • Feature

Purpose

@tk0miya tk0miya added type:enhancement enhance or introduce a new feature domain labels Feb 13, 2020
@tk0miya tk0miya added this to the 3.0.0 milestone Feb 13, 2020
@tk0miya tk0miya force-pushed the 7144_styling_desc_by_domainname branch from 1bc56f9 to 87856cc Compare February 13, 2020 09:05
@tk0miya tk0miya force-pushed the 7144_styling_desc_by_domainname branch from 87856cc to 333596d Compare February 16, 2020 13:31
(".//dt[@id='autodoc_target.Class']", ''),
(".//dt[@id='autodoc_target.function']/em", r'\*\*kwds'),
(".//dl[@class='py class']/dt[@id='autodoc_target.Class']", ''),
(".//dl[@class='py function']/dt[@id='autodoc_target.function']/em", r'\*\*kwds'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change, py class will be added into <dl> element. So users can give a custom style only for python functions via this class and CSS selector.

Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya
Copy link
Member Author

tk0miya commented Feb 22, 2020

Thank you for reviewing!

@tk0miya tk0miya merged commit 58a7cd2 into sphinx-doc:master Feb 22, 2020
@tk0miya tk0miya deleted the 7144_styling_desc_by_domainname branch February 22, 2020 09:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
domain type:enhancement enhance or introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants