Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "test: Disable codecov" #7303

Merged
merged 2 commits into from
Mar 14, 2020
Merged

Revert "test: Disable codecov" #7303

merged 2 commits into from
Mar 14, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 12, 2020

Reverts 1dba840.

Will investigate (from) here.

@blueyed blueyed changed the title [WIP] Fix coverage reporting (Revert "test: Disable codecov") Revert "test: Disable codecov" Mar 12, 2020
@blueyed
Copy link
Contributor Author

blueyed commented Mar 12, 2020

Seems to work (again).

While the config/setup can be improved, I'd suggest to re-enable it for now already.

This avoids having unrelated files being collected.
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your work!

@@ -59,6 +59,7 @@ markers =
apidoc
setup_command
test_params
testpaths = tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk0miya tk0miya merged commit 491048d into sphinx-doc:3.x Mar 14, 2020
@tk0miya tk0miya added this to the 3.0.0 milestone Mar 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants