Fix #4187: latex: EN DASH disappears from PDF bookmarks in Japanese documents #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Mar 14, 2020
| @@ -129,6 +129,7 @@ def init(self) -> None: | |||
| self.document_data = [] # type: List[Tuple[str, str, str, str, str, bool]] | |||
| self.themes = ThemeFactory(self.app) | |||
| self.usepackages = self.app.registry.latex_packages | |||
| self.usepackages_after_hyperref = self.app.registry.latex_packages_after_hyperref | |||
There was a problem hiding this comment.
I need a help to give a better name to this member...
tk0miya
force-pushed
the
4187_endash_on_pdf_bookmarks
branch
from
4384d32
to
71bd8e4
Compare
tk0miya
force-pushed
the
4187_endash_on_pdf_bookmarks
branch
from
71bd8e4
to
6c324be
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose