Safe formatting of translatable strings #8954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Safe formatting of translatable strings
Feature or Bugfix
Purpose
There are 100+ languages, which is enough for Murphy's law to take effect if anything is imperfect.
The error recently fixed for Spanish (#8943) similarly exists in Hungarian and Greek.
Rather than fixing them individually (and have them come back in new translations), this fix changes the strings so the error cannot occur again. This of course invalidates the translations. Let me know if I should attempt to adapt the translations as well, but state of the art i18n wisdom is that it's best left to translators.
(I specify 3.5.x as target branch, but if merged, this should probably be merged/cherrypicked to master etc. as well.)
Detail
Current faulty translations:
Relates
#8943