Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial for extending autodoc #8972

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Tutorial for extending autodoc #8972

merged 4 commits into from
Mar 9, 2021

Conversation

igo95862
Copy link
Contributor

@igo95862 igo95862 commented Mar 8, 2021

Subject: Tutorial for extending autodoc

Feature or Bugfix

  • Feature

Purpose

  • Document the add_documenter method of SphinxApp

Detail

  • This is only part of tutorial. It missing the available documenter classes, options.
  • I can either continue working on this pull request or create new pull request in the future.
  • Not sure about the format, grammar. Please give feedback.

Relates

@igo95862 igo95862 changed the title Master Tutorial for extending autodoc Mar 8, 2021
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

doc/development/tutorials/autodoc_ext.rst Outdated Show resolved Hide resolved
.. autointenum:: my_enums.Colors


.. todo:: Document available Documenter classes, options...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a topic of tutorials. It would be better to separate class references and tutorials.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to remove this todo?

Copy link
Contributor Author

@igo95862 igo95862 Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After going through the autodoc source code I got a very strong urge to make changes to the code. I want to ask the mailing list first about my proposed changes. I will probably create a separated API page after making changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to remove this todo?

Yes. It's better to document it on another page.

doc/development/tutorials/examples/autodoc_intenum.py Outdated Show resolved Hide resolved
doc/development/tutorials/autodoc_ext.rst Outdated Show resolved Hide resolved
doc/development/tutorials/autodoc_ext.rst Outdated Show resolved Hide resolved
doc/development/tutorials/autodoc_ext.rst Outdated Show resolved Hide resolved
@tk0miya tk0miya added this to the 4.0.0 milestone Mar 8, 2021
@igo95862
Copy link
Contributor Author

igo95862 commented Mar 8, 2021

@tk0miya Do you want me to push new commits or amend?

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

@tk0miya
Copy link
Member

tk0miya commented Mar 9, 2021

Thank you for update. Looks good. Can I merge this?

@igo95862
Copy link
Contributor Author

igo95862 commented Mar 9, 2021

Yes

@tk0miya tk0miya merged commit 3693ffe into sphinx-doc:master Mar 9, 2021
@tk0miya
Copy link
Member

tk0miya commented Mar 9, 2021

Merged! Thank you for your work!

@igo95862 igo95862 deleted the master branch May 16, 2021 12:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants