-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Switch to pydata-sphinx-theme #1013
Conversation
this given that this simplifies our config a bit and matches what a bunch of other scientific packages are doing (numpy, scipy, matplotlib, scikit-learn, etc.)
I think that we should maybe tweak it a tiny bit to have a distinguishable visual identity, but using it is definitely a good idea, because it will ensure that our css choices work well with what others are doing.
|
Is it possible to add a left sidebar containing all sections? html_theme_options = {
"navigation_depth": 2
} ? |
Hi folks - I checked this branch locally and managed to build the docs by pinning |
Okay I got CIs happy and restructured things a bit to fit into the structure pydata-sphinx-theme prefers. I don't think this is perfect but I think it's good enough to merge and iterate on separately:
For this I created an "icon" using an emoji, which is hopefully good enough until someone with more artistic skills can make a pass on the design :) Good enough for now @lucyleeow @GaelVaroquaux ? Also @melissawm since you showed some interest and got me working on this again :) -- if you have specific usability suggestions you'd like to push, feel free to make a PR based on my to my fork and I'll merge it there, then we can hopefully merge here! |
@larsoner thanks for the ping - I think this looks amazing, thanks for this 🚀 |
We'll get a new pydata-sphinx-theme release out soon I promise! If you like, try out the RC and provide feedback so we don't break something! |
* upstream/master: TST: gallery inventory/re-structure tinybuild (sphinx-gallery#1072) MAINT: Fix CIs (sphinx-gallery#1074)
@choldgraf the failure here seems like a bug in pydata-sphinx-theme:
note the extra |
Argh wait no I think this is my error, let me confirm... |
All green! I'll merge this so we can start trying this out. Fingers crossed it doesn't cause any problems... |
Seems to be working |
Nice!
I must say that I have no love for the choice of colors in the dark mode of this theme (the light mode is fine, but the theme picks up the dark mode on my computer).
|
I hit a bug during doc build I thought was due to
sphinx_rtd_theme
, so I decided to trypydata-sphinx-theme
to see if it would fix it. It didn't, but given that this simplifies our config a bit and matches what a bunch of other scientific packages are doing (numpy, scipy, matplotlib, scikit-learn, etc.) let's see if it looks good enough to keep. (Or really, seems like it's headed in a good enough direction to tweak a little bit more then merge!)