fix(core): Resolve bug sending transactions on polygon mainnet #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes an issue where the
getGasPriceOverridesfunction returns a gas price that causes transactions to hang on polygon mainnet. This is due to an underlying bug in how Ethers interacts with Polygons implementation of EIP-1559. This issue has been natively resolved in Ethers v6, but migrating to the new Ethers version is non trivial so I've implemented a simple workaround. However, we should migrate to Ethers v6 when we have time for it as this workaround does not fully resolve the issue. This workaround simply makes it possible to send transactions on polygon using Ethers, but it's somewhat unreliable (I had to restart the core contract deployment process 3 times before it fully completed).