Add ability to develop new features quickly via an external file #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to pass a path to an alternative version of
detprocess/process/_features.pyfor fast development of new or one-off features. The change is that theexternal_filekeyword argument was added todetprocess.process_data, to which a path to a file which contains the Python code for features to extract. With this update, the code loads theSingleChannelExtractorsclass from that file instead of the default version, and uses the functions therein for feature extraction. This allows the user to create new features on the fly without needing to rebuild the package each time.The documentation has also been updated to discuss how to use this optional keyword argument in
detprocess.process_datawhen an external file is desired.