Do not double alias Exprs

UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs

Author: sgrebnov

datafusion/expr/src/expr.rs

@@ -497,6 +497,19 @@ impl Alias {
         self.metadata = metadata;
         self
     }
+
+    /// Return true if this alias represents the unaliased `name`
+    pub fn eq_name(&self, name: &str) -> bool {
+        self.eq_qualified_name(None, name)
+    }
+
+    pub fn eq_qualified_name(
+        &self,
+        relation: Option<&TableReference>,
+        name: &str,
+    ) -> bool {
+        self.relation.as_ref() == relation && self.name == name
+    }
 }
 
 /// Binary expression
@@ -1386,7 +1399,14 @@ impl Expr {
 
     /// Return `self AS name` alias expression
     pub fn alias(self, name: impl Into<String>) -> Expr {
-        Expr::Alias(Alias::new(self, None::<&str>, name.into()))
+        // Don't nest aliases
+        let Expr::Alias(mut alias) = self else {
+            return Expr::Alias(Alias::new(self, None::<&str>, name.into()));
+        };
+
+        alias.relation = None;
+        alias.name = name.into();
+        Expr::Alias(alias)
     }
 
     /// Return `self AS name` alias expression with metadata
@@ -1407,7 +1427,16 @@ impl Expr {
         name: impl Into<String>,
         metadata: Option<std::collections::HashMap<String, String>>,
     ) -> Expr {
-        Expr::Alias(Alias::new(self, None::<&str>, name.into()).with_metadata(metadata))
+        // Don't nest aliases
+        let Expr::Alias(mut alias) = self else {
+            return Expr::Alias(
+                Alias::new(self, None::<&str>, name.into()).with_metadata(metadata),
+            );
+        };
+
+        alias.relation = None;
+        alias.name = name.into();
+        Expr::Alias(alias.with_metadata(metadata))
     }
 
     /// Return `self AS name` alias expression with a specific qualifier
@@ -1416,7 +1445,14 @@ impl Expr {
         relation: Option<impl Into<TableReference>>,
         name: impl Into<String>,
     ) -> Expr {
-        Expr::Alias(Alias::new(self, relation, name.into()))
+        // Don't nest aliases
+        let Expr::Alias(mut alias) = self else {
+            return Expr::Alias(Alias::new(self, relation, name));
+        };
+
+        alias.relation = relation.map(|r| r.into());
+        alias.name = name.into();
+        Expr::Alias(alias)
     }
 
     /// Return `self AS name` alias expression with a specific qualifier and metadata
@@ -1438,7 +1474,14 @@ impl Expr {
         name: impl Into<String>,
         metadata: Option<std::collections::HashMap<String, String>>,
     ) -> Expr {
-        Expr::Alias(Alias::new(self, relation, name.into()).with_metadata(metadata))
+        // Don't nest aliases
+        let Expr::Alias(mut alias) = self else {
+            return Expr::Alias(Alias::new(self, relation, name).with_metadata(metadata));
+        };
+
+        alias.relation = relation.map(|r| r.into());
+        alias.name = name.into();
+        Expr::Alias(alias.with_metadata(metadata))
     }
 
     /// Remove an alias from an expression if one exists.