Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 4, 2025

Which issue does this PR close?

Rationale for this change

Nested Expr::Alias is confusing for display and for dealing with code

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) labels Mar 4, 2025
@github-actions github-actions bot added the optimizer Optimizer rules label Mar 5, 2025
This was referenced Mar 4, 2025
@alamb
Copy link
Contributor Author

alamb commented Mar 5, 2025

Let's go with @blaginin 's version here:

@alamb alamb closed this Mar 5, 2025
phillipleblanc added a commit to spiceai/datafusion that referenced this pull request May 7, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
sgrebnov pushed a commit to spiceai/datafusion that referenced this pull request May 22, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895

# Conflicts:
#	datafusion/expr/src/expr.rs
sgrebnov added a commit to spiceai/datafusion that referenced this pull request May 24, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
sgrebnov added a commit to spiceai/datafusion that referenced this pull request May 24, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
sgrebnov added a commit to spiceai/datafusion that referenced this pull request May 26, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
sgrebnov added a commit to spiceai/datafusion that referenced this pull request May 26, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
kczimm pushed a commit to spiceai/datafusion that referenced this pull request Aug 19, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
Jeadie pushed a commit to spiceai/datafusion that referenced this pull request Sep 9, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
Jeadie pushed a commit to spiceai/datafusion that referenced this pull request Sep 12, 2025
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed

This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplicated alias in Sort

1 participant