Allow adding custom scalar to sql overrides for DuckDB #68
+32
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Allow adding custom scalar to sql overrides for DuckDB, for example
Concern
This is a breaking change for DuckDB as we are adding new field so
DuckDBDialect {}must be replaced withDuckDBDialect::new()constructor, I've tried to avoid this by using Default trait but it does not help, with this change we require to update the wayDuckDBDialectis created. Note: DuckDB was added by us so most likely only us are affected by this change.I was thinking to add
fn get_custom_scalar_overrides()->Option<&HashMap<String, ScalarFnToSqlHandler>>to Dialect Trait as an example of what Dialects should use to provide custom overrides but I don't think we should restrict how Dialects should implement this. We haveType ScalarFnToSqlHandler = Box<dyn Fn(&Unparser, &[Expr]) -> Result<Option<ast::Expr>> + Send + Sync>that specifies the signature and this should be enough for dialects IMO.