Improve error message for unsupported protobuf version #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekim
reviewed
Oct 25, 2024
| @@ -138,6 +138,11 @@ public FlightStream query(String sql) throws ExecutionException { | |||
| } catch (RetryException e) { | |||
| Throwable err = e.getLastFailedAttempt().getExceptionCause(); | |||
| throw new ExecutionException("Failed to execute query due to error: " + err.toString(), err); | |||
| } catch (ExecutionException e) { | |||
| if (isUnsupportedProtobufVersionException(e.getCause())) { | |||
| throw new ExecutionException("Unsupported protobuf version has been detected. Please upgrade 'com.google.protobuf' dependency to version 3.25.x or later.", e); | |||
There was a problem hiding this comment.
Should note which version was detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Improve error message for unsupported (older) protobuf version conflicting with required one.
Note: tried several approaches to detect the Protobuf version at runtime, but they were unreliable, often returning null. As a result, I'm detecting Protobuf issues using a specific exception type and message during the query call.