Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding custom User-Agent to client #121

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Adding custom User-Agent to client #121

merged 5 commits into from
Nov 25, 2024

Conversation

slyons
Copy link
Contributor

@slyons slyons commented Nov 21, 2024

🗣 Description

  • Adding a custom user-agent to spicepy to improve the identification of the client when making requests.
  • Changing header from x-spice-user-agent to standard User-Agent

🔨 Related Issues

🤔 Concerns

@slyons slyons added the enhancement New feature or request label Nov 21, 2024
@slyons slyons self-assigned this Nov 21, 2024
sgrebnov
sgrebnov reviewed Nov 21, 2024
View reviewed changes
spicepy/_http.py Outdated Show resolved Hide resolved
@slyons @sgrebnov
Update spicepy/_http.py
678e465 
Co-authored-by: Sergei Grebnov <sergei.grebnov@gmail.com>
@phillipleblanc phillipleblanc merged commit 8a27c04 into trunk Nov 25, 2024
16 checks passed
@phillipleblanc phillipleblanc deleted the slyons/custom_user_agent branch November 25, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgrebnov sgrebnov sgrebnov approved these changes

Assignees

@slyons slyons

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slyons @sgrebnov @phillipleblanc