Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The class name for the historyButtons is wrong #1398

Closed
ajiou opened this issue Jan 9, 2022 · 3 comments
Closed

The class name for the historyButtons is wrong #1398

ajiou opened this issue Jan 9, 2022 · 3 comments
Labels
🐛 bug Something isn't working

Comments

@ajiou
Copy link
Contributor

ajiou commented Jan 9, 2022

ℹ Computer information

  • Spotify version: 1.1.76
  • Spicetify version: 2.8.4

📝 Provide detailed reproduction steps (if any)

None

✔️ Expected result

Back button should be main-topBar-back
Forward button should be main-topBar-forward

❌ Actual result

Otherwise

📷 Screenshots

image
@ajiou ajiou added the 🐛 bug Something isn't working label Jan 9, 2022
@github-actions
Copy link

Marking this issue as stale.

Let someone know if I'm wrong, after all, I'm just a bot!

@github-actions github-actions bot added the ☠️ stale Stale issue or PR label Jan 25, 2022
@afonsojramos
Copy link
Member

On my machine they are actually not even mapped :/

@afonsojramos afonsojramos removed the ☠️ stale Stale issue or PR label Jan 25, 2022
afonsojramos pushed a commit that referenced this issue Jan 31, 2022
@huhridge
fix: Wrong class names for historyButtons #1398 (#1440)
78c3048
@ajiou
Copy link
Contributor Author

ajiou commented Jan 31, 2022

fixed

@ajiou ajiou closed this as completed Jan 31, 2022
afonsojramos pushed a commit that referenced this issue Feb 4, 2022
@huhridge
fix: add instrumental to lyrics-plus + ability to play stations with …
aa015a5 
…auto-shuffle (#1446)

* fix: Wrong class names for historyButtons #1398

* added Instrumental to lyrics-plus #1369

Note: Even though I have added instrumental for both Netease and musixmatch, I would recommend to put musixmatch over netease in provider order.

also added the case where if a provider only has unsynced lyrics, rest are also gone through to check if there are synced ones.

* fixed formatting to pass prettier

* ability to play stations with auto-shuffle on fixing #1448

Since there is no simple way, to get the queue of a radio, added a workaround to play with original play function.

* fixed formatting (again)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afonsojramos @ajiou