fix(new-releases): use getContents for getArtistsList
#3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machinemessiah
commented
Aug 6, 2024
machinemessiah
changed the title
getArtistsList fixgetArtistsList fix
rxri
requested changes
Aug 6, 2024
rxri
changed the title
getArtistsList fixgetContents for getArtistsList
More efficient and with a 0 count check Co-authored-by: em <hey@ririxi.dev>
rxri
approved these changes
Aug 6, 2024
|
and where are the comments mate? |
|
Maybe post your review first then ask where are the comments. I already told you so in discord dms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore
getArtistListfunctionality by usingLibraryAPI.getContentsto perform the same operation that was previously handled byLibraryAPI.getArtistswhich no longer exists.