fix: issue 3176 fixed to Enable Enter on Search in keyboard shortcut extension #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AishwaryaAgr
changed the title
AishwaryaAgr
changed the title
|
That's not how it should be fixed though. You're listening for this event on whole document which shouldn't be a thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#3176 Enable Enter on Search
Description:
This pull request introduces a new feature that allows the focus to change when the user presses the "Enter" key while an input field is active in the keyboardShortcut.js. This enhancement enables users to use the navigation by clicking "f" to control the app.
Changes:
Added an event listener for the "Enter" key press on input fields.
When "Enter" is pressed, the focus is removed from the input field.
Ensured the default action of the "Enter" key is prevented to avoid unwanted form submissions.
Testing:
Tested the functionality in multiple browsers to verify consistent behavior.
Verified that the focus correctly shifts when pressing "Enter" on the active input.