future.cr -> async #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspiano
reviewed
Jan 11, 2021
|
The team that maintains this library has its own asynchronous abstraction of Fibers as Promise. We've been using that library in production for a while now and I currently don't have the bandwidth to review your library. I'll merge once I have had time to dig through your library. |
|
Sounds good man, just trying to help close some issues while I also create some new ones |
|
Tagged it wrong initially so the build failed, but it should pass now |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Figured I'd go ahead and PR this and see how you feel about it. As mentioned in #7, my
Async::Futureis a bit more powerful than the oldFuturethat use to be in the standard library. I've tried to take inspiration from both Python's asyncio and JavaScript's promises.