Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(client): fix blocking and async mixture #39

Merged
merged 1 commit into from
Apr 21, 2022
Merged

perf(client): fix blocking and async mixture #39

merged 1 commit into from
Apr 21, 2022

Conversation

j-mendez
Copy link
Member

  1. fix mixing async runtime with blocking dispatch causing use of reqwest pool_max_idle_per_host which does not dispatch properly upon the async task completion outside the current thread.

Screen Shot 2022-04-21 at 10 20 50 AM

-- TODO

Move crawl to fully async api with crawl_sync or blocking counter part.

Now the sync bench marks can properly be compared against node, go, and rust for crawling.

@j-mendez j-mendez force-pushed the perf/fix-client-network branch 16 times, most recently from 2d7471d to af3a056 Compare April 21, 2022 16:33
@j-mendez j-mendez merged commit 1efc75e into master Apr 21, 2022
@j-mendez j-mendez deleted the perf/fix-client-network branch April 21, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-mendez