Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle page get errors #4

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Handle page get errors #4

merged 3 commits into from
Jan 27, 2021

Conversation

Dragnucs
Copy link
Contributor

@Dragnucs Dragnucs commented Jan 26, 2021

This is my attempt at handling page get errors.

PS: I am new to Rust and my proposition might not be the best.

Copy link
Contributor

@madeindjs madeindjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR 👍

This seem good, I just have a suggestion about println

src/page.rs Outdated Show resolved Hide resolved
src/page.rs Outdated Show resolved Hide resolved
Dragnucs and others added 2 commits January 27, 2021 19:45
Co-authored-by: Alexandre Rousseau <contact@rousseau-alexandre.fr>
Co-authored-by: Alexandre Rousseau <contact@rousseau-alexandre.fr>
@Dragnucs
Copy link
Contributor Author

@madeindjs Thank you for the suggestion. In have applied it.

@madeindjs madeindjs merged commit 5ff0674 into spider-rs:master Jan 27, 2021
@Dragnucs Dragnucs deleted the patch-3 branch January 28, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants