Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherrypick]fix spiderpool-agent crashes when kubevirt static IP feature is off #2987

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

Icarus9913
Copy link
Collaborator

Reference: #2971

Signed-off-by: Icarus9913 icaruswu66@qq.com

…ure is off

Signed-off-by: Icarus9913 <icaruswu66@qq.com>
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca5fd1f) 81.06% compared to head (3159f72) 81.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.8    #2987      +/-   ##
================================================
- Coverage         81.06%   81.00%   -0.06%     
================================================
  Files                49       49              
  Lines              5339     5339              
================================================
- Hits               4328     4325       -3     
- Misses              854      856       +2     
- Partials            157      158       +1     
Flag Coverage Δ
unittests 81.00% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Collaborator

@ty-dc ty-dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是必须的手动 cherry-pick,由于上个 PR 修改 sign-off 时,使用了参数 --signed ,导致cherry-pick 失败,同时未生成 PR 和 Issue,需要手动处理。

@cyclinder cyclinder merged commit 6beb82a into spidernet-io:release-v0.8 Dec 26, 2023
40 checks passed
@Icarus9913 Icarus9913 deleted the cherrypick2971 branch December 26, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug pr/ready-review This pull is ready for review release/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants