Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherrypick]fix inherit subnet properties for ippool failure #3022

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

Icarus9913
Copy link
Collaborator

close #3016

Signed-off-by: Icarus9913 icaruswu66@qq.com

Signed-off-by: Icarus9913 <icaruswu66@qq.com>
@Icarus9913 Icarus9913 added pr/ready-review This pull is ready for review release/none no release note release/bug labels Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (218c048) 80.98% compared to head (9fc0386) 80.98%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-v0.7    #3022   +/-   ##
=============================================
  Coverage         80.98%   80.98%           
=============================================
  Files                49       49           
  Lines              5274     5275    +1     
=============================================
+ Hits               4271     4272    +1     
  Misses              845      845           
  Partials            158      158           
Flag Coverage Δ
unittests 80.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/ippoolmanager/ippool_mutate.go 97.14% <100.00%> (ø)
pkg/subnetmanager/subnet_informer.go 43.58% <100.00%> (+0.13%) ⬆️

@Icarus9913 Icarus9913 removed the release/none no release note label Dec 27, 2023
@weizhoublue weizhoublue merged commit b029996 into spidernet-io:release-v0.7 Dec 27, 2023
35 checks passed
@Icarus9913 Icarus9913 deleted the cherrypick3011-v7 branch January 11, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-review This pull is ready for review release/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to cherry pick PR 3011 from Icarus9913, to branch release-v0.7
2 participants