Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the parent interface is down, set it to up before creating the vlan sub-interface #3089

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

weizhoublue
Copy link
Collaborator

robot cherry pick PR #3088 from ty-dc,to branch release-v0.7, action https://github.com/spidernet-io/spiderpool/actions/runs/7523903858 , commits d990b82

fix: the parent interface is down, set it to up before creating the vlan sub-interface
Signed-off-by: robot <tao.yang@daocloud.io>
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (814760d) 81.04% compared to head (5af9739) 80.98%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.7    #3089      +/-   ##
================================================
- Coverage         81.04%   80.98%   -0.06%     
================================================
  Files                49       49              
  Lines              5275     5275              
================================================
- Hits               4275     4272       -3     
- Misses              843      845       +2     
- Partials            157      158       +1     
Flag Coverage Δ
unittests 80.98% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@weizhoublue weizhoublue merged commit 41714bc into release-v0.7 Jan 15, 2024
32 of 34 checks passed
@weizhoublue weizhoublue deleted the robot/cherrypick/pr3088/release-v0.7 branch January 15, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants