spidercoordinator: Enhance the edge case #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
added
release/bug
cherrypick-release-v0.8
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
spidercoordinator/hander_patch
branch
from
1f5c542
to
04fedd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3284 +/- ##
=======================================
Coverage 81.12% 81.12%
=======================================
Files 50 50
Lines 5372 5372
=======================================
Hits 4358 4358
Misses 856 856
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
weizhoublue
approved these changes
Mar 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
spidercoordinator: Enhance the edge case Signed-off-by: robot <tao.yang@daocloud.io>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
spidercoordinator: Enhance the edge case Signed-off-by: robot <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Consider a successful fetch of the kube-controller-manager podList, but maybe the podList is empty, which may result in a panic.
Which issue(s) this PR fixes:
Fixes #3285
Special notes for your reviewer: