Remove some of the excessive permissions granted and fix the issue #3361 #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: houqiyu <qiyuhou2@gmail.com>
|
Hi @HouqiyuA Thanks for the PR! It looks like something is broken while you remove the permissions, Are you able to fix the CI failure? thank you so much for your attention and participation. |
|
Sorry！I noticed that someone seems to be working on fixing this problem,
and I can't continue fixing it, not being very good at raising PR.By the
way,Can spiderpool team reward our team after fixiing this problem? For
example, apply for a CVE ID to our team for this problem or other ways?
Cyclinder ***@***.***>于2024年5月1日 周三22:26写道：
… Hi @HouqiyuA <https://github.com/HouqiyuA> Thanks for the PR! It looks
like something is broken while you remove the permissions, Are you able to
fix the CI failure? thank you so much for your attention and participation.
—
Reply to this email directly, view it on GitHub
<#3446 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBBY3LVIAESTGBU54QIFUWDZAD3PZAVCNFSM6AAAAABHAORG56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGU2DENRSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I will close it if you don't want to keep working on this issue. @kaaass want to work on this.
Sure, but I don't know how to apply for a CVE ID. |
@cyclinder I can help this! I had DM you in Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Remove some of the excessive permissions granted and fix the issue
Which issue(s) this PR fixes:
#3361
Fixes #3361#
Special notes for your reviewer: