RBAC: avoiding too high permissions leading to potential CVE risks #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waiting for #3603 merged first. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3608 +/- ##
=======================================
Coverage 81.27% 81.27%
=======================================
Files 50 50
Lines 4352 4352
=======================================
Hits 3537 3537
Misses 662 662
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. |
weizhoublue
previously approved these changes
Jun 18, 2024
cyclinder
force-pushed
the
fix_rbac_vulnerability
branch
from
54a0e95
to
01aaee8
Compare
Signed-off-by: cyclinder <qifeng.guo@daocloud>
cyclinder
force-pushed
the
fix_rbac_vulnerability
branch
from
01aaee8
to
81a0c48
Compare
weizhoublue
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
avoiding too high permissions leading to potential CVE risks, see these issues below
Which issue(s) this PR fixes:
Fixes #3420
Fixes #3361
Special notes for your reviewer: