Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: it is so slow to create a Pod requiring IP from a super big CIDR #3629

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Jun 21, 2024

git-cherry-pick #3583

@lou-lan lou-lan changed the base branch from main to release-v0.9 June 21, 2024 07:25
Signed-off-by: lou-lan <loulan@loulan.me>
(cherry picked from commit ba95bce)
@lou-lan lou-lan force-pushed the git-cherry-pick-to-v0.9.0-#3583 branch from 4f2f51f to 9b1e15c Compare June 21, 2024 07:26
@lou-lan lou-lan enabled auto-merge June 21, 2024 07:27
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 74.60317% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (1c0cd94) to head (9b1e15c).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.9    #3629      +/-   ##
================================================
- Coverage         81.12%   81.05%   -0.08%     
================================================
  Files                50       50              
  Lines              5373     5415      +42     
================================================
+ Hits               4359     4389      +30     
- Misses              856      864       +8     
- Partials            158      162       +4     
Flag Coverage Δ
unittests 81.05% <74.60%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/ippoolmanager/ippool_manager.go 85.88% <100.00%> (ø)
pkg/subnetmanager/subnet_validate.go 91.86% <100.00%> (-0.04%) ⬇️
pkg/subnetmanager/subnet_manager.go 41.48% <0.00%> (ø)
pkg/ip/ip.go 87.64% <74.57%> (-5.27%) ⬇️

@weizhoublue weizhoublue changed the title git-cherry-pick: it is so slow to create a Pod requiring IP from a super big CIDR #3628 fix: it is so slow to create a Pod requiring IP from a super big CIDR Jun 23, 2024
@lou-lan lou-lan merged commit 36c2df6 into release-v0.9 Jun 23, 2024
44 of 47 checks passed
@lou-lan lou-lan deleted the git-cherry-pick-to-v0.9.0-#3583 branch June 23, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants