-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: update enableRdma/rdmaIsolation field for spiderMultusConfig #4301
base: main
Are you sure you want to change the base?
api: update enableRdma/rdmaIsolation field for spiderMultusConfig #4301
Conversation
1e0f7cd
to
4dee59d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4301 +/- ##
=======================================
Coverage 79.51% 79.52%
=======================================
Files 53 53
Lines 6252 6255 +3
=======================================
+ Hits 4971 4974 +3
Misses 1088 1088
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
4dee59d
to
fd7b567
Compare
@@ -229,10 +246,6 @@ spec: | |||
- mode | |||
- name | |||
type: object | |||
enableRdma: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 是 破坏性 的 版本 变更,只能说 deprecated ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我也是考虑了一下,目前没有任何地方在引用这个代码,所以感觉可以直接移除?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是代码引用的问题。
升级 流程上 是否能 会问题,存量实例 的转换 怎么办
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
升级指的是老 CRD 用新镜像,因为新镜像不会用到 enableRdma 这个字段,所以不会影响升级。手动测试过都是正常的,我也是考虑到没地方引用这个字段,所以想一步到位
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那不现实的,只换镜像,那不叫升级,不处理 CRD 的升级 和转换。那未来 任何新功能,crd 新的定义,存量环境都享受不到,结果它们升级的意义 只是为了 修复 bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我的意思是即使未升级 CRD只升级镜像测试都没问题,正常升级流程CRD和镜像都要升级,所以更没问题, crd 升级后,crs 中该字段自动移除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否要一步到位, 你决定就好,我都OK @weizhoublue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我的意思是即使未升级 CRD只升级镜像测试都没问题--- 不是一个升级服务的流程,不考虑
正常升级流程CRD和镜像都要升级 --- crd 升级后 删除字段,相关实例 是否能正常,是否有验证
@@ -280,10 +303,6 @@ spec: | |||
- mode | |||
- name | |||
type: object | |||
enableRdma: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同理
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #4267
Special notes for your reviewer:
Remove enableRdma field for macvlan and ipvlan CNI
Make the enableRdma field DEPRECATED for sriov-cni, and use rdmaIsolation instead. which keep consistant with ibsriov-cni.
Update the comments of the spiderMultusConfig fields and docs.