Update to go-jose v4.0.1 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rturner3
requested review from
amartinezfayo,
evan2645 and
azdagron
as code owners
rturner3
commented
Mar 30, 2024
|
This PR depends on #277 to be merged first. |
Closed
There are some breaking changes in v4 that affect go-spiffe code: - When parsing a JWS-protected JWT, the caller must now explicitly pass the accepted signature algorithms (corresponding to `alg` JWS header) into the parsing function. - `CompactSerialize()` was removed in favor of just `Serialize()`, which has identical behavior. go-jose v4 updates the minimum Go version requirement to 1.21, which was released 2023-08-08. Signed-off-by: Ryan Turner <turner@uber.com>
azdagron
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some breaking changes in v4 that affect go-spiffe code:
algJWS header) into the parsing function.CompactSerialize()was removed in favor of justSerialize(), which has identical behavior.go-jose v4 updates the minimum Go version requirement to 1.21, which was released 2023-08-08.