Allow empty x509 bundles to be sent in responses #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
amartinezfayo,
evan2645 and
azdagron
as code owners
This causes the workload to be unable to fetch X509-SVIDs, even though its own trust domain still has a valid trust bundle Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
The specification already allows this to happen: https://github.com/spiffe/spiffe/blob/main/standards/SPIFFE_Trust_Domain_and_Bundle.md\#413-keys Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
sorindumitru
force-pushed
the
empty-bundle
branch
from
a71e8c5
to
e84d8df
Compare
azdagron
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Thanks, @sorindumitru, for catching this misalignment with what is allowed by the spec.
Just a few small nitpicks.
Co-authored-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Co-authored-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
azdagron
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise federating with a trust domain that publishes an empty trust bundle at some point will cause your workloads to stop being able to fetch SVIDs. The only result of that should be the inability to verify SVIDs from the federated trust domain.
The specifications already allows this to happen.