This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Fix missing spiffe-csi-driver imagePullSecrets template #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laith Majeed <laithm98@hotmail.com>
LaithLite
requested review from
marcofranssen,
kfox1111,
developer-guy,
dfeldman,
faisal-memon,
mrsabath and
edwbuck
as code owners
marcofranssen
approved these changes
Jul 3, 2023
marcofranssen
added a commit
that referenced
this pull request
Jul 19, 2023
* 088b296 Improve tornjak service API to have object structure (#392) * 522066e Align tornjak clientCA naming convention (#393) * f05cb4f Add option to configure TLS/mTLS endpoint for Tornjak (#338) * f461a01 Bump test chart dependencies (#386) * ce39e82 Bump test chart dependencies (#382) * 19d3208 Fix oidc provider config change not rolling out (#383) * 0197621 Bump helm/kind-action from 1.7.0 to 1.8.0 (#384) * 3ed1859 Add missing tolerations config to daemonsets (#381) * 4ad68b1 Add namespace to spiffe-oidc-discovery-provider RBAC definitions (#379) * c1b1dd3 Add additional domains to JWT issued items. (#230) * 3405e13 Bump test chart dependencies * 81452d5 Fix missing spiffe-csi-driver imagePullSecrets template (#376) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Jul 19, 2023
* 94a2b72 Merge pull request #324 from spiffe/enable-testing-multiple-charts * e426bc0 Downgrade chart-testing tool to 3.8.0 * 09b4664 Utilize ct install --github-groups in ci workflow * 42086bd Run example tests also on all k8s versions * 4848c48 Improve Makefile help and implementation * db06038 Increase some timeouts, trying to fix the tests * 54ed71f Add back tests for examples * 4b4cef1 Skip namespace-override test because of #330 * 380979c Prevent ci folder ending up in Helm package * 06ddb7c Use chart-testing ci/*-values.yaml for testing * a4c1de7 Add basic unit test framework (#390) * 088b296 Improve tornjak service API to have object structure (#392) * 522066e Align tornjak clientCA naming convention (#393) * f05cb4f Add option to configure TLS/mTLS endpoint for Tornjak (#338) * f461a01 Bump test chart dependencies (#386) * ce39e82 Bump test chart dependencies (#382) * 19d3208 Fix oidc provider config change not rolling out (#383) * 0197621 Bump helm/kind-action from 1.7.0 to 1.8.0 (#384) * 3ed1859 Add missing tolerations config to daemonsets (#381) * 4ad68b1 Add namespace to spiffe-oidc-discovery-provider RBAC definitions (#379) * c1b1dd3 Add additional domains to JWT issued items. (#230) * 3405e13 Bump test chart dependencies * 81452d5 Fix missing spiffe-csi-driver imagePullSecrets template (#376) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spiffe-csi-driver sub-chart describes in its
README.mdthat it supports animagePullSecretvalue, however the helm templating functionality is missing in thedaemonset.yaml.The following PR adds the missing functionality, replicated using existing logic in other sub-charts.