Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches to pin to a specific python version #248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ajessup
Copy link
Member

@ajessup ajessup commented Jul 29, 2022

Avoids the following error when running make docker-serve by pinning python to a specific version

 => ERROR [ 9/14] RUN pyenv install                                                                                     1.9s 
------                                                                                                                       
 > [ 9/14] RUN pyenv install:                                                                                                
#13 1.593 python-build: definition not found: 3.8

Signed-off-by: Andrew Jessup ajessup@gmail.com

Signed-off-by: Andrew Jessup <ajessup@gmail.com>
@ajessup
Copy link
Member Author

ajessup commented Jul 29, 2022

@mchurichi Would love your review on this if possible please

@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for spiffe ready!

Name Link
🔨 Latest commit f0b64a5
🔍 Latest deploy log https://app.netlify.com/sites/spiffe/deploys/65c3d923af02ce0007d4a943
😎 Deploy Preview https://deploy-preview-248--spiffe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amoore877
Copy link
Member

amoore877 commented Aug 8, 2022

The CI errors are a bit confusing considering the netlify bot was still able to make a site preview

@mchurichi
Copy link
Member

The first build for this PR failed because of #250. Subsequent builds have succeeded, but for some reason Github checks aren't picking them up.

Anyways, I think we need some research before merging this, as we already found an issue with pinning to an exact/patch version as stated in #239.

@amoore877
Copy link
Member

@ajessup maybe if you re-push this PR it will trigger CI to update?

@amoore877
Copy link
Member

looks like CI is fixed now after the re-push :)

@amoore877
Copy link
Member

amoore877 commented Nov 2, 2022

@sanderson042 @evan2645 @mchurichi @Andres-GC @umairmkhan this is ready for approval and merge

Anyways, I think we need some research before merging this, as we already found an issue with pinning to an exact/patch version as stated in #239.

has this researching been completed?

@amoore877
Copy link
Member

are we able to merge this? is it still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants