Add support for building/testing with podman #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
requested review from
sanderson042,
mchurichi,
ajessup,
Andres-GC,
evan2645 and
umairmkhan
as code owners
✅ Deploy Preview for spiffe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kfox1111
commented
Jan 24, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM klakegg/hugo:0.68.3-ext | |||
| FROM docker.io/klakegg/hugo:0.68.3-ext | |||
There was a problem hiding this comment.
docker.io is the default when not specified in docker, but podman by default prompts you for verification when not specified.
sanderson042
approved these changes
Jan 30, 2024
|
Anyone know why the required "Mixed content" test seems to be stuck? |
I did a quick search and found this. Netlify has deprecated something that looks like we are using. Just in case it's something else, could you push a small commit to re-trigger the build? |
kfox1111
commented
Jan 31, 2024
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
kfox1111
added a commit
to kfox1111/spiffe.io
that referenced
this pull request
Feb 22, 2024
* Add support for building/testing with podman Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update Makefile Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
added a commit
to kfox1111/spiffe.io
that referenced
this pull request
Feb 24, 2024
* Add support for building/testing with podman Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update Makefile Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
added a commit
to kfox1111/spiffe.io
that referenced
this pull request
Feb 27, 2024
* Add support for building/testing with podman Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update Makefile Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
added a commit
to kfox1111/spiffe.io
that referenced
this pull request
Mar 5, 2024
* Add support for building/testing with podman Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update Makefile Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
mchurichi
added a commit
that referenced
this pull request
Apr 3, 2024
* Adds PR template Signed-off-by: Maximiliano Churichi <mchurichi@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add support for building/testing with podman Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add initial documentation for the help-charts-hardened chart Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add ingress documentation Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add basic federation docs and misc fixes Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add recommendations, some nested spire docs, and misc changes Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Remove unneeded bits Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add Namespace documentation Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add initial mirroring docs Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update docs for external agents Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Can't use controller manager with join tokens Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * More examples Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Make image better Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update diagrams Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update things Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Reorder docs Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * More updates Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add join token details Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Better diagram Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Break out ready docs from nonready Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/installation.md Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Fix typo Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add support for building/testing with podman (#289) * Add support for building/testing with podman Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update Makefile Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/exposing.md Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/exposing.md Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/identifiers.md Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Removed HeadBucket Signed-off-by: Quintessence <quintessenceanx@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update install instructions Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Co-authored-by: Maximiliano Churichi <mchurichi@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/recommendations.md Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * add VMware Secrets Manager as a consumer (#301) Signed-off-by: Volkan Özçelik <ovolkan@vmware.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Co-authored-by: Maximiliano Churichi <mchurichi@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Maximiliano Churichi <mchurichi@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> Signed-off-by: Quintessence <quintessenceanx@gmail.com> Signed-off-by: Volkan Özçelik <ovolkan@vmware.com> Co-authored-by: Maximiliano Churichi <mchurichi@gmail.com> Co-authored-by: Faisal Memon <fymemon@yahoo.com> Co-authored-by: Quintessence <quintessenceanx@gmail.com> Co-authored-by: Volkan Özçelik <volkan.ozcelik@gmail.com>
quintessence
added a commit
to quintessence/spiffe.io-fork
that referenced
this pull request
May 7, 2024
) * Adds PR template Signed-off-by: Maximiliano Churichi <mchurichi@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add support for building/testing with podman Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add initial documentation for the help-charts-hardened chart Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add ingress documentation Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add basic federation docs and misc fixes Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add recommendations, some nested spire docs, and misc changes Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Remove unneeded bits Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add Namespace documentation Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add initial mirroring docs Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update docs for external agents Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Can't use controller manager with join tokens Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * More examples Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Make image better Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update diagrams Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update things Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Reorder docs Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * More updates Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add join token details Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Better diagram Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Break out ready docs from nonready Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/installation.md Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Fix typo Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Add support for building/testing with podman (spiffe#289) * Add support for building/testing with podman Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update Makefile Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/exposing.md Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/exposing.md Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/identifiers.md Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Removed HeadBucket Signed-off-by: Quintessence <quintessenceanx@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update install instructions Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Co-authored-by: Maximiliano Churichi <mchurichi@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Update content/docs/latest/spire-helm-charts-hardened-about/recommendations.md Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * add VMware Secrets Manager as a consumer (spiffe#301) Signed-off-by: Volkan Özçelik <ovolkan@vmware.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Apply suggestions from code review Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Co-authored-by: Maximiliano Churichi <mchurichi@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Maximiliano Churichi <mchurichi@gmail.com> Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov> Signed-off-by: Quintessence <quintessenceanx@gmail.com> Signed-off-by: Volkan Özçelik <ovolkan@vmware.com> Co-authored-by: Maximiliano Churichi <mchurichi@gmail.com> Co-authored-by: Faisal Memon <fymemon@yahoo.com> Co-authored-by: Quintessence <quintessenceanx@gmail.com> Co-authored-by: Volkan Özçelik <volkan.ozcelik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.