Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit tests for internal/auth and app/keeper/env packages #65

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

abhishek44sharma
Copy link

No description provided.

Signed-off-by: ABHISHEK SHARMA <abhisheksharma@ABHISHEKs-Mac-mini.local>
@v0lkan
Copy link
Contributor

v0lkan commented Dec 31, 2024

Thanks for the contribution @abhishek44sharma 🚀

Will check it out next year :D

@v0lkan v0lkan assigned v0lkan and abhishek44sharma and unassigned v0lkan Jan 2, 2025
@v0lkan
Copy link
Contributor

v0lkan commented Jan 2, 2025

Thanks @abhishek44sharma 🙏 .

Merging these.

I'll run all the unit tests (there are a few other test contributions too) on the main branch and ensure they all pass.

There is also an automation work, so I'm hoping to be less of a human Jenkins in the future :D

Cheers.

@v0lkan v0lkan merged commit d10e5a1 into spiffe:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants