Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attested node deletion doesn't clean node resolver data #3872

Closed
guilhermocc opened this issue Feb 16, 2023 · 0 comments · Fixed by #3873
Closed

Attested node deletion doesn't clean node resolver data #3872

guilhermocc opened this issue Feb 16, 2023 · 0 comments · Fixed by #3873
Labels
priority/urgent Issue is approved and is must be completed in the assigned milestone
Milestone
1.6.3

Comments

@guilhermocc
Copy link
Contributor

guilhermocc commented Feb 16, 2023 •
edited
Loading

  • Version: main branch
  • Platform: all platforms
  • Subsystem: server - datastore

Currently, when the datastore's DeleteAttestedNode method is evaluated, It cleans any entry data related to the provided entryID in the attested_node_entries table, but related node resolver data on node_resolver_map_entries remains in the database. Apparently, we have no usage for this data once the attested node entry is deleted, so this data should also be deleted in the process. I wasn't able to find any logical reason in the code to keep this data in the database after node entry deletion, but if there is, I would be happy to know.

PS: If we definitely don't have any use for the data that's left behind, I would be happy to act on this fix since it relates to another issue that I'm working on right now (#1836). 😄
@rturner3 rturner3 added triage/in-progress Issue triage is in progress priority/urgent Issue is approved and is must be completed in the assigned milestone and removed triage/in-progress Issue triage is in progress labels Feb 16, 2023
@guilhermocc guilhermocc mentioned this issue Feb 16, 2023
Merged
3 tasks
@MarcosDY MarcosDY added this to the 1.6.1 milestone Feb 21, 2023
@guilhermocc guilhermocc mentioned this issue Feb 24, 2023
Closed
@amartinezfayo amartinezfayo modified the milestones: 1.6.2, 1.6.3 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/urgent Issue is approved and is must be completed in the assigned milestone
Projects
None yet
Milestone
1.6.3
Development

Successfully merging a pull request may close this issue.

Clean node resolver map entries on attested node deletion guilhermocc/spire
4 participants
@MarcosDY @rturner3 @amartinezfayo @guilhermocc